puppetlabs / puppetlabs/puppetlabs-java

The install_path variable can leads to corrective actions at every run

Open
#604 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
101
Forks
274
Avg merge
1h 33m
Merged PRs (30d)
1

Description

The install_path variable from the download.pp file can leads to a corrective actions at every run in some cases.

In our case we download the openjdk in tar.gz format from an URL and the folder created by the archive extraction has a different format the the format specified in the install_path variable:

The variable value should be:
$install_path = "${java_se}-${release_major}.${release_minor}"
instead of:
$install_path = "${java_se}${release_major}${release_minor}"

perhaps the variable should support other formats or be configurable ?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in download.pp and compare the install_path value with the folder name produced when OpenJDK is downloaded as a tar.gz archive. Confirm the expected naming format and determine whether the variable should be configurable; done means repeated runs no longer report corrective actions for this case.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
devops
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.