puppetlabs / puppetlabs/puppetlabs-docker

docker::plugin should implecitly require Docker class

Open
#890 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug community
Dominant language
Ruby
Stars
94
Forks
337
Avg merge
11d 15h
Merged PRs (30d)
2

Description

Describe the Bug

When using docker::plugin an error is raised when provisioning a VM for the first time. this instruction is executed without checking whether the Docker class is called or not.

==> XXXX: Error: /Stage[main]/XXXXXXX/Docker::Plugin[XXXXXXXX/file-log-driver:2.0]/Exec[plugin enable XXXXXXXX/file-log-driver:2.0]: Could not evaluate: Could not find command 'docker'

Expected Behavior

docker::plugin should call Docker implicitly Docker class

Steps to Reproduce

Steps to reproduce the behavior:
Include docker::plugin on a puppet class

    docker::plugin {'plugin_name':}

Environment

  • Puppet Version 7.21 (module version 6.0.2)
  • Platform Ubuntu 22.04 (5.x)

Thanks!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the docker::plugin resource in this Puppet Docker module and reproduce the first-time VM provisioning failure using the example declaration. Confirm that declaring the plugin also makes the Docker class available before the plugin enable command runs, and verify that the missing docker command error no longer occurs.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker
Domain
devops
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.