puppetlabs / puppetlabs/puppetlabs-docker
*_docker_params_changed is notified every time puppet runs, regardless of status
Open
Nobody has claimed this yet.
attention-needed
bug
community
- Dominant language
- Ruby
- Stars
- 94
- Forks
- 337
- Avg merge
- 11d 15h
- Merged PRs (30d)
- 2
Description
Describe the Bug
docker::run instances are restarted on each puppet run, regardless of whether any params have actually changed. This is using restart => 'unless-stopped', so not using the systemd approach.
Expected Behavior
Instances should not restart if params have not changed.
Environment
- Version 4.1.2
- Platform Ubuntu 20.04
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the docker::run implementation and its parameter-change notification path first, since the issue names no files or tests. Reproduce the Puppet run with restart => 'unless-stopped', then verify unchanged parameters no longer restart instances.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, ruby
- Domain
- devops
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100