puppetlabs / puppetlabs/puppetlabs-apache
OIDCUnAuthAction does not support boolean expression
Nobody has claimed this yet.
- Dominant language
- Puppet
- Stars
- 356
- Forks
- 1.1k
- Avg merge
- 3m
- Merged PRs (30d)
- 1
Description
Use Case
mod_auth_openidc supports adding a boolean expression after "OIDCUnAuthAction {action}" to specify conditions that should be met to override the default action. This module seems to prohibit configuring that option for UnAuthAction.
Describe the Solution You Would Like
The system should accept configuration like:
oidc_settings => {
'UnAuthAction' => 'pass "%{HTTP_ACCEPT} !~ m#text/html#"',
...
},
Describe Alternatives You've Considered
I could work around this issue by changing the spec in types/oidcsettings.pp to:
Optional['UnAuthAction'] => Pattern[/^(auth|pass|401|407|410)\s.*/],
Additional Context
OIDC Settings Documentation: here
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with types/oidcsettings.pp and compare the UnAuthAction pattern with the documented mod_auth_openidc syntax linked in the issue. Verify that the supplied pass expression configuration is accepted while the existing allowed actions remain supported.
Written by the indexing model from the issue text.
Assessment
- Domain
- authentication, devops
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100