puppetlabs / puppetlabs/puppetlabs-apache
mod_remoteip doesn't add RemoteIpHeader in vhost
- Dominant language
- Puppet
- Stars
- 356
- Forks
- 1.1k
- Avg merge
- 3m
- Merged PRs (30d)
- 1
Description
Describe the Bug
When using apache::mod::remote_ip the vhost doesn't get edited and the keywords aren't added. Therefore the remoteip isn't working, because the X-Forwarded-For header isn't set if apache get's used by a loadbalancer
Expected Behavior
I expect the RemoteIPHeader X-Forwarded-For to be set in the vhost if the module is used
Steps to Reproduce
Steps to reproduce the behavior:
- create an apache managed with puppet and served by a loadbalancer which also uses the X-Forwarded-For Header
- Use the apache::mod::remote_ip
- See, that it's not working because a flag is missing in the vhost
Environment
- Version [e.g. 1.27.0]
- Platform [e.g. Ubuntu 18.04]
Additional Context
Add any other context about the problem here.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review linked pull request #2512 first, then trace the apache::mod::remote_ip entry point and the vhost generation it affects. Confirm whether the reported RemoteIPHeader X-Forwarded-For behavior is addressed there; done means the module produces the expected vhost configuration and the relevant checks pass.
Written by the indexing model from the issue text.
Assessment
- Domain
- devops, infrastructure
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100