puppetlabs / puppetlabs/puppet-editor-services

Linting does not use .puppet-lint.rc

Open
#43 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Ruby
Stars
52
Forks
21
Avg merge
15h
Merged PRs (30d)
3

Description

Cross ref: https://github.com/lingua-pupuli/puppet-vscode/issues/304

Original author: @setaou


What Versions are you running?

OS Version: Ubuntu 18.04
VSCode Version: 1.24.1
Puppet Extension Version: 0.10.0
Puppet Agent Version: 4.10.4

What You Are Seeing?

I have a .puppet-lint.rc file at the root of my workspace containing only the following line :
--no-140chars-check

If I use the puppet-lint command from a terminal, it uses this config file and ignores the warnings about long lines. However, the linting in vscode still shows the warnings.

What is Expected?

The linting in vscode should enforce the options set in .puppet-lint.rc.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue by running puppet-lint from a terminal and comparing it with VSCode linting in a workspace containing a .puppet-lint.rc file. Trace the VSCode linting entry point and verify that the configured --no-140chars-check option is honored when the long-line warning is evaluated.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby, vscode
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
40/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.