puppetlabs / puppetlabs/puppet-editor-services
Puppet Facts Endpoint Refresh
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 52
- Forks
- 21
- Avg merge
- 15h
- Merged PRs (30d)
- 3
Description
The primary reason I had not pulled from cache was that it means waiting for the language server to start and for the language server to run before querying, but I was able to set the promises in the client to wait. It works, and is slightly faster start because there isn't a second wait for the facts to be queried.
So it all works with cached facts. However, hitting refresh doesn't 'refresh' anymore. It pulls from teh cache. How does a user get a 'fresh' run?
Originally posted by @jpogran in https://github.com/puppetlabs/puppet-editor-services/pull/246#issuecomment-621309833
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the cached-facts behavior described in the issue and the referenced pull request #246, focusing on how the language-server client handles refresh and fact queries. Done means the refresh action can trigger a fresh facts run rather than returning cached facts.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100