puppetlabs / puppetlabs/puppet-editor-services

Add guards for incompatible parameters in language server

Open
#19 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

maintenance
Dominant language
Ruby
Stars
52
Forks
21
Avg merge
15h
Merged PRs (30d)
3

Description

With https://github.com/lingua-pupuli/puppet-vscode/pull/188 merged we need to update options parser so that incompatible options throw errors.

i.e.

  • Can't use ip or port with the stdio transport
  • Can't use --debug=STDOUT with the stdio transport

Relates to https://github.com/lingua-pupuli/puppet-vscode/pull/187

https://github.com/lingua-pupuli/puppet-vscode/issues/191

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the language server's options parser and review how the stdio transport handles command-line options. The change is complete when incompatible ip or port options, and --debug=STDOUT, raise errors when stdio transport is selected; the referenced pull requests and issue provide additional context.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.