puppetlabs / puppetlabs/pe_patch
Phase out egrep since it triggers warnings on grep version >= 3.8
Open
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 4
- Forks
- 1
- Avg merge
- 44m
- Merged PRs (30d)
- 1
Description
Affected Puppet, Ruby, OS and module versions/distributions
- Puppet: all
- Ruby: all
- Distribution: any distro with grep >= 3.8 (Fedora 38 in particular)
- Module version: all
How to reproduce (e.g Puppet code you use)
Run the script /opt/puppetlabs/pe_patch/pe_patch_fact_generation.sh on a distro with grep >= 3.8
What are you seeing
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
What behaviour did you expect instead
No output
Output log
Any additional information you'd like to impart
Since we have the script running in a cron job, we do get multiple emails per day per system. It adds up.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with /opt/puppetlabs/pe_patch/pe_patch_fact_generation.sh and run it on a system using grep >= 3.8, such as Fedora 38. Done means the script produces no obsolescence warnings when run from the cron job.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- shell
- Domain
- devops
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100