pulumi / pulumi/pulumi-java

GHA JAR comparison correctness

Open
#337 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area/build kind/enhancement
Dominant language
Java
Stars
85
Forks
26
Avg merge
11h 49m
Merged PRs (30d)
22

Description

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Enhance GHA to define the proper old JAR we want to benchmark against and make sure it's getting the proper old JAR as publishing matures.

Comments by @t0yv0 on

  • #327

This is really worrisome to me that it's inline with the main build and YAML quickly grows. What's worrisome is that one day we will accidentally build the wrong jar and publish the wrong jar or else test the wrong jar.

Would it be possible to checkout the old version and perhaps separate this size check a little more?

I guess we're fine for now but we can revisit later on if we refactor/grow this build file.

One possibility is that we have SNAPSHOT builds published from main into the Maven repo. Those can be a point of comparison without rebuilding.

Affected area/feature

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the repository's GitHub Actions workflow and the context in #327. Determine how the old JAR is selected for benchmarking, then define and verify a stable comparison against the intended published artifact without relying on an accidentally wrong build output.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, java
Domain
build-system, ci-cd, release
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.