Simplify Deployment APIs
Open
Nobody has claimed this yet.
area/languages
kind/enhancement
language/java
- Dominant language
- Java
- Stars
- 85
- Forks
- 26
- Avg merge
- 11h 49m
- Merged PRs (30d)
- 22
Description
Hello!
- Vote on this issue by adding a 👍 reaction
- To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already)
Issue details
Review Deployment related APIs for opportunities to simplfiy.
Notes from Pawel (from #1):
- deployment related internal APIs could use a cleanup, I was not sure what were the requirements so I couldn't do an informed refactoring, but esp. those needs to be looked at:
- https://github.com/pulumi/pulumi-java/blob/d302f9c049ac7a9653d56e9073ca3f091be0ace9/sdk/jvm/pulumi/src/main/java/io/pulumi/deployment/internal/DeploymentInstanceInternal.java
- https://github.com/pulumi/pulumi-java/blob/d302f9c049ac7a9653d56e9073ca3f091be0ace9/sdk/jvm/pulumi/src/main/java/io/pulumi/deployment/internal/DeploymentInternal.java
- https://github.com/pulumi/pulumi-java/blob/d302f9c049ac7a9653d56e9073ca3f091be0ace9/sdk/jvm/pulumi/src/main/java/io/pulumi/deployment/internal/DeploymentImpl.java#L60
- https://github.com/pulumi/pulumi-java/blob/d302f9c049ac7a9653d56e9073ca3f091be0ace9/sdk/jvm/pulumi/src/main/java/io/pulumi/deployment/DeploymentInstance.java
Steps to reproduce
Expected:
Actual:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing DeploymentInstanceInternal.java, DeploymentInternal.java, DeploymentImpl.java around line 60, and DeploymentInstance.java. Determine the requirements and relationships among these deployment APIs before proposing a simplification; done means the internal deployment API design has been cleaned up without losing required behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- api
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100