Enable dependabot PRs to run tests
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 85
- Forks
- 26
- Avg merge
- 11h 49m
- Merged PRs (30d)
- 22
Description
PRs from dependabot (and other external contributors) do not run examples tests, but do run some integration tests. The integration tests that do run give a false sense that the PR is OK to merge, but can lead to failures in master (e.g. upgrading grpc requires additional manual updates to the minimal example).
One idea from @t0yv0 is to move minimal under test_integrations as a quick fix.
Another idea is to do what we did in the https://github.com/pulumi/pulumi-dotnet repo and fix the tests to not depend on any secrets.
From @t0yv0:
Looks like we could do this easily https://github.com/pulumi/pulumi-java/tree/main/tests/examples
Nothing here looks like valuable with cloud-deps anymore. This must be historic dependency we used to test on AWS builds, etc
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting tests/examples and test_integrations, especially the minimal example, to understand which tests run for external pull requests. Compare the secret-free test setup in pulumi-dotnet and decide between moving minimal or removing cloud dependencies. Done means Dependabot and other external pull requests run the relevant examples tests without secrets and cannot leave master broken.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- aws, grpc, java
- Domain
- ci-cd, cloud, testing
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100