Move common duplicated code from plugins to pulpcore
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 598
- Forks
- 168
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 86
Description
The has_task_completed function is duplicated across at least the container plugin and the maven plugin
Significant portions of the Maven and Rust plugins contain similar-if-not-identical code for e.g. storing cached content
In any such cases it would make sense to put as much code as possible into Pulpcore rather than copy+paste between plugins
There are also conventions for things such as URL slugs, and domain handling, that could potentially be made more similar across plugins
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the duplicated has_task_completed function in the container and Maven plugins, then compare the similar cached-content code in the Maven and Rust plugins. Review how these plugins currently implement URL slugs and domain handling. Done means identifying agreed common behavior and moving suitable shared code into pulpcore without plugin-specific duplication.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100