pulp / pulp/pulpcore

Pin djangorestframework to 3.15.1

Open
#5,978 3 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Issue
Dominant language
Python
Stars
598
Forks
168
Avg merge
1d 4h
Merged PRs (30d)
86

Description

Right now djangorestframework to 3.15.2 ships with one dir that was intent to be created only by the documentation example:

├── djangorestframework.egg-info
├── LICENSE.md
├── MANIFEST.in
├── PKG-INFO
├── README.md
├── rest_framework
├── setup.cfg
├── setup.py
├── tests
└── tutorial
 tree tutorial/
tutorial/
├── asgi.py
├── __init__.py
├── quickstart
│   ├── admin.py
│   ├── apps.py
│   ├── __init__.py
│   ├── migrations
│   │   └── __init__.py
│   ├── models.py
│   ├── serializers.py
│   ├── tests.py
│   └── views.py
├── settings.py
├── urls.py
└── wsgi.py

In the RPM side of packaging this is easy to solve, we can just add the macro %exclude , for users installing from pypi this might be a problem. We caught this here https://github.com/theforeman/pulpcore-packaging/pull/1323

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read requirements.txt at the referenced line and review the reported djangorestframework 3.15.2 package contents. Update the dependency to 3.15.1, then verify that the package version no longer includes the unintended tutorial directory for PyPI users.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.