Pulp is running gunicorn's cli parser on startup.
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 598
- Forks
- 168
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 86
Description
Version
pulp>=3.44,<3.51
Describe the bug
From this change: https://github.com/pulp/pulpcore/commit/55043f31b0adf00353a8c7b64c03c0a93106287b, Pulp began loading the gunicorn defaults when starting. Part of gunicorn default loading is parsing the arguments passed in: https://github.com/benoitc/gunicorn/blob/master/gunicorn/app/base.py#L158. This happens to work since we mostly duplicate every option for our entrypoints. However our --limit-request-field-size option does not match what gunicorn uses: --limit-request-field_size (https://docs.gunicorn.org/en/stable/settings.html#limit-request-field-size). If you specify this option you will get an error when gunicorn parses the cli args.
We shouldn't let gunicorn parse our cli args.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing commit 55043f31b0adf00353a8c7b64c03c0a93106287b and gunicorn/app/base.py, especially the argument parsing described in the issue. Reproduce startup with --limit-request-field-size, then verify that Pulp's entrypoints start without gunicorn parsing their arguments and that the option no longer causes an error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend, cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100