pulp / pulp/pulpcore

Provide pulp_rpm urlencode solution to plugins via the plugin API

Open
#2,950 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Feature
Dominant language
Python
Stars
598
Forks
168
Avg merge
1d 4h
Merged PRs (30d)
86

Description

Is your feature request related to a problem? Please describe.
pulp_deb users have reported the following issue: https://github.com/pulp/pulp_deb/issues/571
It looks like pulp_rpm has solved the exact same issue for pulp_rpm a long time ago here under this issue.

Describe the solution you'd like
Since this now affects multiple plugins, it would be nice if the pulp_rpm solution could be provided to plugins by pulpcore.
Ideally using the downloader from pulpcore would "just work" for everyone, but given the ongoing design discussions around downloaders and the pulp_rpm solution describing itself as "a pretty ugly workaround" perhaps just provide it as a small utility function requiring opt-in from plugin authors?

Describe alternatives you've considered
We simply copy the pulp_rpm fix within pulp_deb and maybe wait for the "Pulp downloader redesign" to conclude before asking for a general solution from pulpcore.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the existing workaround in pulp_rpm/app/downloaders.py with pulpcore's downloader and the plugin API. Review the linked downloader redesign discussion before deciding how an opt-in utility should be exposed; done means multiple plugins can use the shared urlencode behavior without copying the workaround.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api, backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.