As a user, I have checks that are run when starting Pulp and when I run "pulpcore-manager check"
Open
Nobody has claimed this yet.
Feature
- Dominant language
- Python
- Stars
- 598
- Forks
- 168
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 86
Description
Author: daviddavis (daviddavis)
Redmine Issue: 8265, https://pulp.plan.io/issues/8265
Right now we have checks in two different places in our application:
The first set of checks aren't being run except by Katello. This is because "checks are not run as part of the WSGI stack that is used in deployment".
We should standardize on one approach to checks that will be run:
- When the
pulpcore-manager checkcommand is run - When pulpcore is run as part of a WSGI stack
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the checks in pulpcore/app/checks.py and the settings checks in pulpcore/app/settings.py around lines 274-345. Compare how pulpcore-manager check and the WSGI deployment path invoke checks. Done means one standardized check approach runs in both contexts.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend, cli
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100