Remote.get_downloader() needs to include remote in kwargs for Factory.build()
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 598
- Forks
- 168
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 86
Description
Author: @dkliban (dkliban@redhat.com)
Redmine Issue: 6965, https://pulp.plan.io/issues/6965
The plugin writer docs need to be updated to explain how custom downloaders should be implemented. The documenation should be based on the information provided in comment 2 of this issue.
Original Description
Multiple plugins now override Remote.get_downloader() method in order to add the 'remote' to the kwargs[0].
The pulpcore implementation of Remote.get_downloader() should pass the 'remote' as a kwarg to the Factory.build() method[1].
[0] https://github.com/pulp/pulp_container/blob/master/pulp_container/app/models.py#L251
[1] https://github.com/pulp/pulpcore/blob/master/pulpcore/download/factory.py#L108
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing pulp_container/app/models.py and pulpcore/download/factory.py, the implementation points linked in the issue. Find the plugin writer documentation and update it to explain how custom downloaders should be implemented, including the remote keyword argument passed to Factory.build().
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- Half a day
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100