cache.external_cache_secret does not get updated in Pulp CR
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 88
- Forks
- 66
- Avg merge
- 53m
- Merged PRs (30d)
- 1
Description
Version
Please provide the versions of the pulp-operator and pulp images in use.
helm -n pulp list
NAME NAMESPACE REVISION UPDATED STATUS CHART APP VERSION
pulp pulp 1 2024-09-03 16:54:04.919341315 +0300 EEST deployed pulp-operator-0.1.0 1.0.1-beta.4
default images
Describe the bug
When changing field cache.external_cache_secret value and then applying it using 'kubectl apply -f pulp.yaml'
apiVersion: repo-manager.pulpproject.org/v1beta2
kind: Pulp
metadata:
name: pulp
namespace: pulp
spec:
object_storage_s3_secret: s3-secret
database:
# when changing pulp-postgresql env values, update secret suffix here
external_db_secret: pulp-postgresql-secret-kfd8672bgh
cache:
enabled: true
external_cache_secret: pulp-redis-secret-8h6c85m7d4
api:
replicas: 2
resource_requirements:
requests:
cpu: 250m
memory: 256Mi
limits:
cpu: 1
memory: 512Mi
content:
replicas: 2
resource_requirements:
requests:
cpu: 250m
memory: 256Mi
limits:
cpu: 500m
memory: 512Mi
worker:
replicas: 4
resource_requirements:
requests:
cpu: 500m
memory: 500Mi
limits:
cpu: 2
memory: 1Gi
Now check what are the actual running Pulp CR properties:
$ kubectl -n pulp get pulp -oyaml
apiVersion: v1
items:
- apiVersion: repo-manager.pulpproject.org/v1beta2
kind: Pulp
metadata:
annotations:
kubectl.kubernetes.io/last-applied-configuration: |
{"apiVersion":"repo-manager.pulpproject.org/v1beta2","kind":"Pulp","metadata":{"annotations":{},"name":"pulp","namespace":"pulp"},"spec":{"api":{"replicas":2,"resource_requirements":{"limits":{"cpu":1,"memory":"512Mi"},"requests":{"cpu":"250m","memory":"256Mi"}}},"cache":{"enabled":true,"external_cache_secret":"pulp-redis-secret-8h6c85m7d4"},"content":{"replicas":2,"resource_requirements":{"limits":{"cpu":"500m","memory":"512Mi"},"requests":{"cpu":"250m","memory":"256Mi"}}},"database":{"external_db_secret":"pulp-postgresql-secret-kfd8672bgh"},"object_storage_s3_secret":"s3-secret","worker":{"replicas":4,"resource_requirements":{"limits":{"cpu":2,"memory":"1Gi"},"requests":{"cpu":"500m","memory":"500Mi"}}}}}
creationTimestamp: "2024-09-05T08:15:23Z"
generation: 35
name: pulp
namespace: pulp
resourceVersion: "44167475287"
uid: c4b2e685-c6d1-4ca6-ab07-ae34a165f567
spec:
admin_password_secret: pulp-admin-password
api:
gunicorn_timeout: 90
gunicorn_workers: 2
replicas: 2
resource_requirements:
limits:
cpu: 1
memory: 512Mi
requests:
cpu: 250m
memory: 256Mi
cache:
enabled: true
external_cache_secret: pulp-redis-secret-88tk2thgc5
container_auth_private_key_name: container_auth_private_key.pem
container_auth_public_key_name: container_auth_public_key.pem
container_token_secret: pulp-container-auth
content:
gunicorn_timeout: 90
gunicorn_workers: 2
replicas: 2
resource_requirements:
limits:
cpu: 500m
memory: 512Mi
requests:
cpu: 250m
memory: 256Mi
database:
external_db_secret: pulp-postgresql-secret-kfd8672bgh
db_fields_encryption_secret: pulp-db-fields-encryption
deployment_type: pulp
image: quay.io/pulp/pulp-minimal
image_pull_policy: IfNotPresent
image_version: stable
image_web: quay.io/pulp/pulp-web
image_web_version: stable
mount_trusted_ca: false
object_storage_s3_secret: s3-secret
pulp_secret_key: pulp-secret-key
worker:
replicas: 4
resource_requirements:
limits:
cpu: 2
memory: 1Gi
requests:
cpu: 500m
memory: 500Mi
status:
admin_password_secret: pulp-admin-password
conditions:
- lastTransitionTime: "2024-09-09T10:01:09Z"
message: pulp operator tasks running
reason: OperatorRunning
status: "False"
type: Pulp-Operator-Finished-Execution
- lastTransitionTime: "2024-09-09T10:01:09Z"
message: Reconciling pulp-server Secret
reason: UpdatingSecret
status: "False"
type: Pulp-API-Ready
- lastTransitionTime: "2024-09-09T10:01:10Z"
message: Reconciling pulp-content Deployment
reason: UpdatingDeployment
status: "False"
type: Pulp-Content-Ready
- lastTransitionTime: "2024-09-09T10:04:39Z"
message: Worker deployment not ready yet
reason: UpdatingWorkerDeployment
status: "False"
type: Pulp-Worker-Ready
- lastTransitionTime: "2024-09-05T08:15:25Z"
message: All Web tasks ran successfully
reason: WebTasksFinished
status: "True"
type: Pulp-Web-Ready
container_token_secret: pulp-container-auth
db_fields_encryption_secret: pulp-db-fields-encryption
deployment_type: pulp
external_cache_secret: pulp-redis-secret-88tk2thgc5
image: quay.io/pulp/pulp-minimal:stable
last_deployment_update: "2024-09-09T10:01:09Z"
object_storage_s3_secret: s3-secret
pulp_secret_key: pulp-secret-key
kind: List
metadata:
resourceVersion: ""
external_cache_secret is pulp-redis-secret-88tk2thgc5 but should be pulp-redis-secret-8h6c85m7d4
To Reproduce
Change cache.external_cache_secret value and appy changes.
Change is not reflected in Pulp CR in Kube cluster.
Expected behavior
Secret name is updated.
Deplyment is not ready due to broken secret that can't be updated to new secret.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Pulp custom resource's cache.external_cache_secret field and reproduce the update with kubectl apply -f pulp.yaml, then inspect the operator reconciliation path for the Pulp CR. Verify the fix by changing the secret name and confirming the CR and dependent deployment use the new value without the broken-secret state.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, kubernetes
- Domain
- infrastructure
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100