pulp / pulp/pulp-cli-deb

Create distribution command is missing the repository href_pattern

Open
#157 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
5
Forks
14
Avg merge
22h 12m
Merged PRs (30d)
1

Description

Describe Issue

The pulp deb distribution create command allows for the --repository parameter to parse an href:

Usage: pulp deb distribution create [OPTIONS]

  Create a apt distribution.

Options:
  --base-path TEXT
  --publication TEXT  Publication to be served.
  --repository TEXT   Repository to be used for auto-distributing. Specified
                      as '[[<plugin>:]<type>:]<name>' or as href.
  --name TEXT         [required]
  --help              Show this message and exit.

However the HREF_PATTERN is not provided. This causes the following: Error: The option repository does not support href.


Possible Fix

Add the PulpAptRepositoryContext.HREF_PATTERN to the distribution command.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the pulp deb distribution create command and inspect how its --repository option handles hrefs. Compare it with PulpAptRepositoryContext.HREF_PATTERN; done means the command accepts a repository href instead of reporting that the option does not support href.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.