psf / psf/requests

PR 5410 got merged but is not in fact merged

Open
#7,620 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
54.3k
Forks
10.4k
Avg merge
16h 43m
Merged PRs (30d)
3

Description

Hello, I was just looking at https://github.com/psf/requests/pull/5410, which says it was merged in https://github.com/psf/requests/commit/f1a94608814a6bdc484233f48b3051dfcb13aa36 but that is not part of main any more.

Was there a rebase of the main branch that happened and erased this change? Should we send it again?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting PR 5410 and commit f1a94608814a6bdc484233f48b3051dfcb13aa36, then compare their history with main. Confirm whether the changes are present under another commit or absent, and document whether the PR should be sent again.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, github
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.