DMTF Redfish fails with 2.32 request module
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 54.3k
- Forks
- 10.4k
- Avg merge
- 16h 43m
- Merged PRs (30d)
- 3
Description
The DMTF redfish is failing with the latest Request module the issue is not seen with requests-2.31.0.
The issue is in file requests/sessions.py, self.prepare_request(req) function where by encoding "%" url converts to "%25" while preparing request url.
Debug -
/usr/local/lib/python3.12/site-packages/requests/sessions.py(564)request()
-> method=method.upper(),
(Pdb) url
'https://[FE80::5200:E6FF:FEB0:457E%eth0]/redfish/v1'
/usr/local/lib/python3.12/site-packages/requests/sessions.py(575)request()
-> prep = self.prepare_request(req)
(Pdb) prep.url
'https://[fe80::5200:e6ff:feb0:457e%25eth0]/redfish/v1'
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in requests/sessions.py at self.prepare_request(req), and reproduce the DMTF Redfish URL with the IPv6 zone identifier %eth0. Compare the prepared URL with requests-2.31.0; done means the zone identifier is preserved rather than becoming %25eth0 while preparing the request.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100