psf / psf/requests

Client Side Certs with session

Open
#5,140 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
54.3k
Forks
10.4k
Avg merge
16h 43m
Merged PRs (30d)
3

Description

Summary.

Trying to get client side certificates to work with session but I'm seeing a difference between the results when making the call with a session and the helper get method.

Expected Result

Calling get with a Session returns the same result as calling requests.get.

Actual Result

Request fails as if the certificate was not passed.

Reproduction Steps

Screen Shot 2019-07-18 at 11 42 00 AM

System Information

$ python -m requests.help
(panopta_env) ➜  ~ python -m requests.help
{
  "chardet": {
    "version": "3.0.4"
  },
  "cryptography": {
    "version": ""
  },
  "idna": {
    "version": "2.8"
  },
  "implementation": {
    "name": "CPython",
    "version": "2.7.16"
  },
  "platform": {
    "release": "18.6.0",
    "system": "Darwin"
  },
  "pyOpenSSL": {
    "openssl_version": "",
    "version": null
  },
  "requests": {
    "version": "2.22.0"
  },
  "system_ssl": {
    "version": "1000212f"
  },
  "urllib3": {
    "version": "1.25.3"
  },
  "using_pyopenssl": false
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the client-certificate request with a Session and with requests.get, using the issue's Python 2.7 and Requests 2.22.0 context. Compare how the certificate is supplied in both calls and add a regression test once the relevant request path is located; done means Session and requests.get produce the same authenticated result.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
networking, security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.