psf / psf/requests

Determining the IP address of server with bad TLS cert.

Open
#4,939 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
54.3k
Forks
10.4k
Avg merge
16h 43m
Merged PRs (30d)
3

Description

Preliminary notes:

  • Thanks for requests!
  • I investigated quite a bit and couldn't find an obvious solution to the issue. Where I looked: documentation, stack overflow, general web search.

Scenario:

  • HTTPS service available via a DNS name mapped to multiple IP addresses.
  • Each such address is handled by a different server.
  • Some of those servers configured with a bad/wrong TLS certificate.

The issue:

  • Requests like requests.get('https://multiple.example.net/') will sometimes succeed TLS validation and other times fail. How to determine the IP address of the server with the bad TLS certificate?

Why?

  • I would like to be able to tell the service provider that their server at IP address "so and so" is presenting a wrong certificate.

The "give me an IP address" solutions I found all assume the HTTP connection has been established and are mostly based in the idea of using streaming mode to get to the underlying socket, calling getpeername() from there.

Those do not work in this scenario given that an requests.exceptions.SSLError exception is properly raised and there's no response object to work with from that point on. Unless the exception holds a reference to the socket, but I couldn't find it there.

Questions:

  • Other than monkey-patching approaches, is there any solution for this challenge I may be missing?
  • If not, should/could requests.exceptions.SSLError include a reference to the socket that lead to the failure, pretty much like all other requests exceptions include a reference to the request and response objects?

Thanks in advance.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the requests.get() scenario with a DNS name resolving to multiple HTTPS servers and a failing certificate. Investigate how requests.exceptions.SSLError is propagated compared with the streaming getpeername() approach; done requires a settled, supported way to identify the failing server or a documented conclusion that this is not exposed.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
networking
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.