protomaps / protomaps/basemaps

Subsurface rivers (tunnel=culvert) are very prominently rendered including labels

Open
#481 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
740
Forks
104
Avg merge
26m
Merged PRs (30d)
2

Description

this is the issue i alluded to in https://github.com/protomaps/basemaps/issues/240#issuecomment-2868762501.

(the other issue -- labels on small basins/ponds rendered when text was much larger than their geometry -- seems to be already resolved in the latest maps).

Description

Labels & waterways of subsurface rivers are rendered quite prominently.
I'd like them to be

  • rendered in a different manner than surface-waterways, or not at all.
  • rendered without labels

The relevant tagging in OSM is waterway=stream layer=-1 tunnel=culvert, example way 1 example way 2

(see also https://wiki.openstreetmap.org/wiki/Tag:tunnel=culvert)

Location
This is very prominent in the city of Aachen (Germany), which is home to several small springs. The related (small) creeks (eg Pau were mostly moved below surface in the city center and are not part of the visible city (wrt landmarks, navigation). The names of the tributaries to the resulting bigger creek Wurm are not commonly known.

Screenshots
Other map impementations:

  • (osm foundation default mapnik style) renders subsurface rivers with a dashed, less prominent style, and doesnt render their labels:
    Image

  • wikimedia maps doesnt render the labels, but still renders subsurface rivers
    Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked maps and the OSM tagging examples for waterway=stream layer=-1 tunnel=culvert, then compare the current rendering with the screenshots of other map implementations. Done means subsurface culvert waterways are hidden or visually distinct from surface waterways and their labels are not rendered.

Written by the indexing model from the issue text.

Assessment

Domain
design
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.