protocolbuffers / protocolbuffers/protobuf

PHP Extension - Inconsistent final modifier for Google\Protobuf\Timestamp

Open
#20,037 9 comments 0 reactions 1 assignee View on GitHub

@bshaffer is already working on this.

Since Feb 5, 2025.

keep open php
Dominant language
C++
Stars
72k
Forks
16.3k
Avg merge
1d 17h
Merged PRs (30d)
140

Description

In PHP C extension implementation of Google\Protobuf\Timestamp is marked as final but not in the native PHP implementation.

This creates inconsistency between the two:

PHP Implementation :
https://github.com/protocolbuffers/protobuf/blob/e3ac4c9342e5393e3fa974a420fc1bbc68e7397a/php/src/Google/Protobuf/Timestamp.php#L82

C Implementation
https://github.com/protocolbuffers/protobuf/blob/e3ac4c9342e5393e3fa974a420fc1bbc68e7397a/php/ext/google/protobuf/wkt.inc#L1616

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.