protocolbuffers / protocolbuffers/protobuf
Include valid proguard config in java protolite library
@googleberg is already working on this.
Since Dec 14, 2022.
- Dominant language
- C++
- Stars
- 72k
- Forks
- 16.3k
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 140
Description
Related to
https://issuetracker.google.com/issues/144631039
and
https://github.com/protocolbuffers/protobuf/issues/6463
What language does this apply to?
Java Protolite
Describe the problem you are trying to solve.
Include necessary proguard definitions to avoid failures in release builds.
Describe the solution you'd like
Include https://github.com/protocolbuffers/protobuf/blob/520c601c99012101c816b6ccc89e8d6fc28fdbb8/java/lite/proguard.pgcfg in the library, so it's applied automatically.
See https://github.com/square/okhttp/blob/master/docs/features/r8_proguard.md for how this feature works in other libraries
Describe alternatives you've considered
Currently every app needs to fail initially, search for the error message and include the same fix.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.