protocolbuffers / protocolbuffers/protobuf-javascript
JS compiler: List of keywords incorrect
Open
Nobody has claimed this yet.
enhancement
good first issue
javascript
triaged
- Dominant language
- JavaScript
- Stars
- 471
- Forks
- 91
- Avg merge
- 3h 57m
- Merged PRs (30d)
- 2
Description
The JS compiler's list of keywords, kKeyword, is actually a list of Java keywords. (it's missing async, await, has transient when it shouldn't, etc.)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/google/protobuf/compiler/js/js_generator.cc around the linked kKeyword definition. Review the current entries against JavaScript keywords, paying attention to the missing async and await entries and the incorrect transient entry. Done means kKeyword represents the JavaScript compiler's keyword list rather than the Java keyword list.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100