protocolbuffers / protocolbuffers/protobuf-javascript

javascript and int64 as map key

Open
#21 6 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug javascript triaged
Dominant language
JavaScript
Stars
471
Forks
91
Avg merge
3h 57m
Merged PRs (30d)
2

Description

What language does this apply to?
javascript

Describe the problem you are trying to solve.
With an int64 message field, one could annotate it with the option [jstype=JS_STRING], but what to do with an int64 map key?

Describe the solution you'd like
Support for [jstype=JS_STRING] option with map key/value(or it's already there, but with different syntax?)

Describe alternatives you've considered

Additional context
I'm using protoc 3.6.1, with proto2 syntax

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. Start by tracing JavaScript map-key generation and the existing jstype handling for int64 fields, using the proto2 and protoc 3.6.1 context as a compatibility constraint. Done means a supported [jstype=JS_STRING] form for int64 map keys or values, with coverage for the resulting generated behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
api
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.