protocolbuffers / protocolbuffers/protobuf-javascript

Clean up exported testing and API surfaces

Open
#147 0 comments 0 reactions 1 assignee View on GitHub

@dibenede is already working on this.

Since Oct 25, 2022.

cleanup triaged
Dominant language
JavaScript
Stars
471
Forks
91
Avg merge
3h 57m
Merged PRs (30d)
2

Description

As of #146, we have a growing number of @export statements that have been added for the sake of closure optimizations while preserving tests. However, a lot of the exported surfaces are deeply internal to the project.

We should try to simplify our exports and perhaps rethink our testing strategy to separate invasive unit tests from more integration-like tests that only need public surfaces.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.