protocolbuffers / protocolbuffers/protobuf-javascript

Remove dependencies on closure library

Open
#135 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

cleanup enhancement triaged
Dominant language
JavaScript
Stars
471
Forks
91
Avg merge
3h 57m
Merged PRs (30d)
2

Description

Depending on the closure library brings in a lot of code that we then have to use closure compiler to remove

In the long run we should invest in dropping these dependencies

This will require an audit but the major pieces are:

  • goog.asserts, for runtime validation, we should build our own predicate functions
  • gooog.crypt.base64 we should look into adding our own base64 encoding/decoding library
  • goog.object/goog.array/goog.string helpers. We sohuld look into depending on modern platform features instead of these ponyfills

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Begin with an audit of the Closure Library dependencies, especially goog.asserts, gooog.crypt.base64, and the goog.object/goog.array/goog.string helpers, then inspect how Closure Compiler removes them; the work is done when the listed dependencies have viable replacements and the project no longer depends on the Closure Library.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
build-system
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.