prompt-toolkit / prompt-toolkit/python-prompt-toolkit

Overriding Ctrl-c to mean "no" for confirm prompt is unintuitive and dangerous.

Open
#848 3 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
10.6k
Forks
815
PR merge metrics
No merged PRs in 30d

Description

Ctrl-c almost always means abort everything and clean up. I've never encountered a situation where it meant no to a yes/no prompt. I'm not even sure when someone would hit Ctrl-c to respond to a yes/no question.

I have no choice but to avoid using the confirm prompt and create my own by copy/pasting the code and removing the offending line.

https://github.com/prompt-toolkit/python-prompt-toolkit/blob/master/prompt_toolkit/shortcuts/prompt.py#L866

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read prompt_toolkit/shortcuts/prompt.py around line 866 and trace how the confirm prompt handles Ctrl-C. Compare that behavior with the issue's expectation that Ctrl-C aborts instead of answering “no”; done means the prompt no longer treats Ctrl-C as a negative response.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.