prompt-toolkit / prompt-toolkit/python-prompt-toolkit
assertion in Completion constructor doesn't propagate to prompt()
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 10.6k
- Forks
- 815
- PR merge metrics
- No merged PRs in 30d
Description
It seems that the assertion at https://github.com/prompt-toolkit/python-prompt-toolkit/blob/7db93560cb1f10c96f4a22816774da63e67e467e/prompt_toolkit/completion/base.py#L37 is handled at https://github.com/prompt-toolkit/python-prompt-toolkit/blob/7db93560cb1f10c96f4a22816774da63e67e467e/prompt_toolkit/eventloop/coroutine.py#L103 but that assertion doesn't propagate back to prompt() and seems to be silently discarded (at least in mycli and pgcli) ...
This can be reproduced by adding assert False at the first line of the Completion constructor and running prompt(), this seems to do nothing and I'd expect prompt() to raise an exception.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading prompt_toolkit/completion/base.py around the Completion constructor and prompt_toolkit/eventloop/coroutine.py around line 103. Reproduce the issue by adding assert False to the constructor and running prompt(), then trace why the assertion is discarded. Done means prompt() propagates the constructor exception instead of silently continuing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100