prompt-toolkit / prompt-toolkit/python-prompt-toolkit

bottom toolbar is flickering when reusing prompt

Open
#547 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
10.6k
Forks
815
PR merge metrics
No merged PRs in 30d

Description

        p = Prompt()
        while True:
            p.prompt("> ", bottom_toolbar="toolbar")

sep-05-2017 00-04-26

after much investigation, it is caused by the output.erase_down() calls of the renderer.

I suppose for the prompt application, you only need to erase down to the bottom toolbar, so one solution is to override the erase_down method of the output?

EDIT, FloatContainer.write_to_screen is also responsible for the flicker when the prompt is near the bottom.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the shown Prompt loop and bottom_toolbar example. Start by tracing the renderer's output.erase_down() calls, then inspect FloatContainer.write_to_screen for the near-bottom case. Done means reusing the prompt no longer causes the bottom toolbar to flicker.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.