prompt-toolkit / prompt-toolkit/python-prompt-toolkit
pt 2.0: `Prompt` object is very different to be subclassed
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 10.6k
- Forks
- 815
- PR merge metrics
- No merged PRs in 30d
Description
At the 2.0 branch, I found that the Prompt is very difficult to be subclassed because the whole app and layout are computed in one big function _create_application. It would be nice to dissect this function into smaller pieces to allow more customizability. For instance, I really want to customize the layout in some way, but it is currently quite impossible.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in rice/deps/prompt_toolkit/shortcuts/prompt.py at _create_application, as identified in the issue. Read how the application and layout are currently computed there, then determine how the function can be split into smaller customizable pieces. Done means Prompt subclasses can customize the layout without restructuring the whole function.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100