prompt-toolkit / prompt-toolkit/python-prompt-toolkit

History search matching anywhere

Open
#532 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
10.6k
Forks
815
PR merge metrics
No merged PRs in 30d

Description

I believe the current history search matches from the start of the string. Could it be updated with an option for matching anywhere in the string?

The enable_history_search could perhaps be updated where the current True and False settings do as they have done, but now there are additional options for enable_history_search=:

  • 'starts-with' (same as current enable_history_search=True setting)
  • 'contains' (matches anywhere in the string).

I may not understand the classes right, but I'm looking at making the change... my thoughts are below:

The actual string search part at each line is hopefully easy, assuming basic python strings are actually used internally:

>>> "King" in "King's landing"
True

>>> "Jon Snow" in "King's landing"
False

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the implementation and tests for the enable_history_search setting, then read how its current True and False modes choose history matches. Define the behavior for the proposed 'starts-with' and 'contains' options, preserve existing boolean behavior, and verify both matching modes with the relevant history-search tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.