prompt-toolkit / prompt-toolkit/python-prompt-toolkit

auto_up should be implemented with event filters

Open
#510 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
10.6k
Forks
815
PR merge metrics
No merged PRs in 30d

Description

It would be nicer if Buffer.auto_up were implemened with event filters. That way, I could easily make it so that up/down don't navigate completion, without having to redefine the rest of the logic (which is admittedly not much).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at Buffer.auto_up in prompt_toolkit/buffer.py, using the linked implementation as the entry point, and inspect how event filters are represented elsewhere in the project. Done means auto_up uses event filters so up/down completion navigation can be customized without redefining the remaining logic.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.