prompt-toolkit / prompt-toolkit/python-prompt-toolkit

HighlightMatchingBracketProcessor should mark unmatched parentheses

Open
#459 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
10.6k
Forks
815
PR merge metrics
No merged PRs in 30d

Description

It would be useful if HighlightMatchingBracketProcessor highlighted unmatched parentheses in red. The existing use of red for marking the cursor is unfortunate, so maybe a brighter color could be used, or you could change the cursor color to something else.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating HighlightMatchingBracketProcessor and inspect how it currently marks matching and unmatched parentheses, as well as how the cursor color is selected. Decide on a distinct color treatment that avoids the stated conflict, then verify that matched, unmatched, and cursor highlighting remain distinguishable.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.