prompt-toolkit / prompt-toolkit/python-prompt-toolkit
create_prompt_layout lacks argument for specifying editing mode
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 10.6k
- Forks
- 815
- PR merge metrics
- No merged PRs in 30d
Description
SearchToolbarControl has a vi_mode argument, but the default of vi_mode=False is effectively immutable for callers of create_prompt_layout, because create_prompt_layout lacks an argument for specifying the editing mode. Consequently, vi mode users are shown an emacs prompt ("I-search: " or "I-search backward:") when searching their history.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate create_prompt_layout and compare its arguments with SearchToolbarControl's vi_mode behavior. Trace how the layout is used for history search, then expose the editing-mode choice so vi-mode users receive vi-appropriate search prompts; verify both emacs and vi behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100