prompt-toolkit / prompt-toolkit/python-prompt-toolkit

Don't crash when a signal handler raises an exception.

Open
#380 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
10.6k
Forks
815
PR merge metrics
No merged PRs in 30d

Description

I believe that signal handlers should not raise exceptions, but still, have a look at what we can do:

https://github.com/ipython/ipython/pull/9867

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the linked IPython pull request and tracing the signal-handling entry points in python-prompt-toolkit. Determine the current behavior when a signal handler raises an exception, then verify that the application no longer crashes in that case and add or update regression coverage if the relevant test location can be identified.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.