prompt-toolkit / prompt-toolkit/python-prompt-toolkit

reverse serach suggestion

Open
#297 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
10.6k
Forks
815
PR merge metrics
No merged PRs in 30d

Description

So when using reverse search, you can either exit while validating (Enter), but you have no way of exiting with just what you have type.

May I suggest to bind <esc> to dismiss search buffer, and set content of the current buffer to the value of search buffer before dismissal ?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the reverse-search interaction and its existing Enter handling, then inspect how key bindings update the current buffer. Verify how Escape is dispatched during validation and how the search buffer is represented. Done means Escape dismisses reverse search while preserving the typed search value in the current buffer, with coverage for that interaction.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.