prompt-toolkit / prompt-toolkit/python-prompt-toolkit
Document.find_start_of_previous_word and Document.find_previous_word_beginning are identical.
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 10.6k
- Forks
- 815
- PR merge metrics
- No merged PRs in 30d
Description
@yyt16384 writes:
I found out that Document.find_start_of_previous_word and Document.find_previous_word_beginning are the same. Should I remove one of them?
See: https://github.com/jonathanslenders/python-prompt-toolkit/pull/253
Yes, we should make sure that the naming is consistent and only one remains.
(We can still create an alias in order to avoid breaking code.)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect Document.find_start_of_previous_word and Document.find_previous_word_beginning and compare the change discussed in pull request 253. Keep one consistent name, preserve the other as an alias if needed for compatibility, and verify that the duplicate behavior is removed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100