prompt-toolkit / prompt-toolkit/python-prompt-toolkit
Speedup AutoSuggestFromHistory
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 10.6k
- Forks
- 815
- PR merge metrics
- No merged PRs in 30d
Description
AutoSuggestFromHistory has a for string in reversed(list(history))
is is likely possible to not convert to a list and reverse iterate is history has getitem & length
I would expect history to have an efficient way to reverse iterate, that should make autosuggestion much faster (and less memory consuming), on shells with large history.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the AutoSuggestFromHistory entry point named in the issue and inspect how history is traversed and what interface it provides. Confirm the behavior with a large shell history, then verify that autosuggestion avoids unnecessary list conversion while preserving reverse-history results and memory use.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli, performance
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100