prompt-toolkit / prompt-toolkit/python-prompt-toolkit
Title: Add an option to disable the "completion_does_nothing" filter
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 10.6k
- Forks
- 815
- PR merge metrics
- No merged PRs in 30d
Description
We have these code for completers:
# When there is only one completion, which has nothing to add, ignore it.
if len(completions) == 1 and completion_does_nothing(
document, completions[0]
):
del completions[:]
This may seem logical, but I don't want this feature.
I hope there will be a parameter to turn it off. Thanks.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the completer implementation containing the completion_does_nothing check and trace how completer options are exposed. Define where the opt-out parameter belongs, then verify that disabling it preserves the single completion and add or update tests for both option settings.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100