Feature request: Complete suggestions using "l" in Vi mode

Open
#2,075 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
66/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Quiet
Tech stack
python
Domain
cli

Research direction

Start by locating the Vi-mode suggestion-completion handling and the existing right-arrow acceptance path; the issue does not name a file or test. Compare the requested behavior with Fish's use of l, then verify that l accepts the current suggestion only in Vi mode and that the relevant completion behavior is covered by tests.

Written by the indexing model from the issue text.

Description

Basically what the title says.

It makes sense to complete suggestions using the "l" key in Vi mode (in addition to the right arrow key), just like the Fish shell does.

I'm using pgcli which makes use of this library.

Dominant language
Python
Stars
10.6k
Forks
815
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from prompt-toolkit/python-prompt-toolkit

All issues in prompt-toolkit/python-prompt-toolkit

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.