prompt-toolkit / prompt-toolkit/python-prompt-toolkit
Pagers might not work
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 10.6k
- Forks
- 815
- PR merge metrics
- No merged PRs in 30d
Description
Hello cross-posting for visibility because I know aider uses prompt_toolkit under the hood.
Not sure how to reproduce this directly with prompt_toolkit but here's where it's usage is defined in aider:
- https://github.com/Aider-AI/aider/blob/4a9447d344847f1deb59746771753129629df18a/aider/commands.py#L618
- https://github.com/Aider-AI/aider/blob/main/aider/io.py#L195
I've noticed pagers are broken...
Repro path:
- Load up
aider(prompt_toolkit) /run more <any sufficiently long file to scroll>- Scroll down a little with
j - Scroll back up with
k
Expected behavior:
The lines should just scroll up and down
Actual behavior:
The cursor skips up lines and swallows some of the lines in between
Demo:
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the pager behavior through aider's aider/commands.py around line 618 and aider/io.py around line 195, using /run more <any sufficiently long file to scroll>. Compare scrolling with j and k; done means moving up and down without skipped lines or swallowed content.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100