prompt-toolkit / prompt-toolkit/python-prompt-toolkit
Honoring custom pythonbreakpoint environment variable
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 10.6k
- Forks
- 815
- PR merge metrics
- No merged PRs in 30d
Description
I use a custom debugger that is set in my environment by the PYTHONBREAKPOINT environment variable.
However, PT 3.0.39 is overriding this choice due to how Application._enable_breakpointhook is being implemented
Specifically, it is checking whether "sys.breakpointhook == sys.breakpointhook" and then setting the debugger to PDB. However, it seems that since I'm using an envvar that this check evaluates to True despite the fact that I am using a custom hook.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at Application._enable_breakpointhook and reproduce the behavior with a custom debugger selected through the PYTHONBREAKPOINT environment variable. Check why the current sys.breakpointhook comparison treats that custom hook as the default. Done means prompt-toolkit no longer overrides the environment-selected debugger; add or update coverage for this case if the surrounding tests are found.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100