prompt-toolkit / prompt-toolkit/python-prompt-toolkit
Bug: Window margins in Floats are transparent to mouse events.
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 10.6k
- Forks
- 815
- PR merge metrics
- No merged PRs in 30d
Description
Dear Jonathon,
When a Float contains a Window with a Margin, mouse events on the margin are sent to whatever is below the Float.
This means, for example, that clicking on a margin in a modal dialog can result in interaction with whatever is below the dialog.
I think the solution would be to clear all mouse events in a Float's WritePosition before the float is written to the screen.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how a Float containing a Window is rendered and how its WritePosition is used before the float reaches the screen. Reproduce the modal-dialog case with a Window margin, then verify that mouse events in the margin no longer reach content below the Float.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100