prompt-toolkit / prompt-toolkit/python-prompt-toolkit

input_dialog validation

Open
#1,715 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
10.6k
Forks
815
PR merge metrics
No merged PRs in 30d

Description

Validation does not work with input_dialog.

how to reproduce the issue

from prompt_toolkit.validation import Validator
from prompt_toolkit.shortcuts import input_dialog
from prompt_toolkit.validation import Validator


def is_number(text):
    return text.isdigit()

validator = Validator.from_callable(
    is_number,
    error_message='This input contains non-numeric characters')

age = input_dialog(title="Age", text="Your age:",
                   validator=validator).run()

print(f"Your age: {age}")

Fill the input dialog with some string (eg: abc) and press tab key to move focus on OK button. Then press enter key.

Output
Your age: abc
Output expected

Error message on focus lost

About the environment
$ python -V
Python 3.11.1
$ pip freeze
prompt-toolkit==3.0.36
wcwidth==0.2.6

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the input_dialog entry point and reproduce the supplied Python example with an invalid value, then trace how validation behaves when focus moves to the OK button. Done means the invalid value is rejected and the validation error is shown instead of returning abc.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.