prompt-toolkit / prompt-toolkit/python-prompt-toolkit
FileHistory: allow logging every entered command (even repeated ones)
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 10.6k
- Forks
- 815
- PR merge metrics
- No merged PRs in 30d
Description
HEAD: 6bdcb9d7e33ab25b665ea9b5ba373471737b1db2
Description
Current Buffer code is not going to append a repeated input to a history: https://github.com/prompt-toolkit/python-prompt-toolkit/blob/master/src/prompt_toolkit/buffer.py#L1381
While this makes sense for InMemoryHistory this makes less sense for a FileHistory which appends a timestamp to each logged command which allows using a history file as an audit log.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/prompt_toolkit/buffer.py around line 1381, where repeated input is currently excluded from history. Trace how FileHistory differs from InMemoryHistory, then verify that repeated commands are appended with timestamps for FileHistory while the existing InMemoryHistory behavior remains unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100